Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Implement EIP-1344: CHAINID opcode in aleth-interpreter #5708

Merged
merged 4 commits into from
Aug 22, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 30, 2019

@gumb0 gumb0 added this to the Istanbul milestone Jul 30, 2019
@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@91e9883). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5708   +/-   ##
=========================================
  Coverage          ?   63.17%           
=========================================
  Files             ?      353           
  Lines             ?    30211           
  Branches          ?     3387           
=========================================
  Hits              ?    19087           
  Misses            ?     9889           
  Partials          ?     1235

@gumb0 gumb0 force-pushed the chainin-opcode-interpreter branch 2 times, most recently from 4c4be07 to 2312b37 Compare August 6, 2019 09:36
@winsvega
Copy link
Contributor

winsvega commented Aug 6, 2019

whats the EIP ?

@gumb0
Copy link
Member Author

gumb0 commented Aug 6, 2019

@winsvega It says in the PR title: https://eips.ethereum.org/EIPS/eip-1344

@gumb0 gumb0 mentioned this pull request Aug 7, 2019
18 tasks
@gumb0 gumb0 force-pushed the chainin-opcode-interpreter branch from 6569d4c to f46ada6 Compare August 15, 2019 09:30
@gumb0 gumb0 force-pushed the chainin-opcode-interpreter branch from a1f0d7a to d9002e0 Compare August 20, 2019 14:04
@gumb0 gumb0 merged commit 67ceda4 into master Aug 22, 2019
@gumb0 gumb0 deleted the chainin-opcode-interpreter branch August 22, 2019 07:43
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants