Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-223: Move to Review #7339

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update EIP-223: Move to Review #7339

merged 2 commits into from
Aug 2, 2023

Conversation

Dexaran
Copy link
Contributor

@Dexaran Dexaran commented Jul 16, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@Dexaran Dexaran requested a review from eth-bot as a code owner July 16, 2023 03:54
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Jul 16, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 16, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Push ERC-223 to Review Update EIP-223: Move to Review Jul 16, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Jul 16, 2023
@Dexaran Dexaran mentioned this pull request Jul 24, 2023
Closed
Pandapip1
Pandapip1 suggested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title cannot contain the EIP number

Pandapip1
Pandapip1 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now.

@eth-bot eth-bot enabled auto-merge (squash) August 2, 2023 20:19
eth-bot
eth-bot approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit c3e8d5a into ethereum:master Aug 2, 2023
13 checks passed
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 223 state from Draft to Review

@Dexaran Dexaran mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dexaran @eth-bot @eip-automerger @xinbenlv @Pandapip1