Update EIP-1559: Remove empty test cases #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
File
|
|
The commit c9aeaef (as a parent of 4b45d7d) contains errors. |
15 tasks
SamWilsn
approved these changes
Feb 22, 2023
fulldecent
pushed a commit
to fulldecent/EIPs
that referenced
this pull request
Mar 13, 2023
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While final core EIPs are supposed to have a complete test cases section, this rule is not currently enforced.
I would argue that the removal of the placeholder is better than keeping it.