EIP-3540: Clarify contract creation failure

[chfast]

Clarify that in case of any of the new contract creation failure conditions all gas provided to the create instruction/transaction is consumed.

Current implementations do not consume all gas for the first condition but do for the second so this is a functional change.

[eth-bot]

All tests passed; auto-merging...

(pass) eip-3540.md

classification
updateEIP

• passed!

[jochem-brouwer]

What is the motivation that all gas has to be consumed?

[chfast]

If you consider the initcode validation is part of initcode execution then this is consistent (because any other failure in initcode execution fails the contract creation and consumes all gas provided).
Moreover, after initcode execution there is runtime code validation and it must consume all gas in case of failure.

[chfast]

For the reference, the EIP-3670: EOF - Code Validation has this situation clarified and it proposes not consuming all the gas. I wasn't aware of this when proposing this change.
Also in EIP-3860: Limit and meter initcode similar check result in "light" failure not consuming all the gas.

Nevertheless, we should discuss it and pick better variant.

[chfast]

There is also performance aspect of this: for initcode execution we need to validate the code and "load" it into internal representation. It may be more efficient to do both in single pass. This do not prevent implementing it with "light" failure, but is strong indicator that initcode validation is part of execution.

[gumb0]

It was originally motivated by suggestions in 3860 discussion, for failures in case initcode larger than limit: ethereum/tests#990 (comment)

So I think arguments in favor not consuming gas for invalid initcode were like:

• no other error checked before initcode execution consumes all gas (maybe not a very big deal still to add one)
• it's arguably better UX - don't burn all gas if we don't have to. (might be especially painful for creation transactions - easy to make mistake in initcode and all your max gas is burnt)

[chfast]

Abandoned. We decided to do it the old way, so not functional change is needed.

[chfast]

See #5907