ERC-5143: Slippage protection for Tokenized Vault ERC #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-5143.md
|
Amxx
changed the title
lightclient
requested changes
Jun 14, 2022
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
SamWilsn
reviewed
Jun 17, 2022
EIPS/eip-5143.md
Outdated
| Implementing This ERC on top of an ERC-4626 contract can be done very easily. It just requires calling the corresponding ERC-4626 function and adding a revert | ||
| check on the returned value. | ||
|
|
||
| ## Alternative approaches |
There was a problem hiding this comment.
Not a valid top level section; I'd recommend putting it inside the Rationale section (so ### Alternative Approaches.)
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
xboehmx33
approved these changes
Jun 19, 2022
xboehmx33
approved these changes
Jun 19, 2022
lightclient
requested changes
Jun 28, 2022
lightclient
approved these changes
Jun 28, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* first draft of the Slippage protection for Tokenized Vault ERC * renaming XXX → 5143 * rename document * update link to discussion * spelling * rewording * Add a reference implementation * Apply suggestions from code review Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * add an Alternative approaches section * Apply suggestions from code review Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * typos * Update EIPS/eip-5143.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.