Fix citation formats [R4R] #2371

fulldecent · 2019-11-12T15:54:12Z

No description provided.

eip-automerger · 2019-11-12T16:46:23Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

EIP 1155 is in state Final, not Draft or Last Call
EIP 137 is in state Final, not Draft or Last Call
EIP 162 is in state Final, not Draft or Last Call
EIP 190 is in state Final, not Draft or Last Call
EIP 1056 requires approval from one of (pelle.braendgaard@consensys.net, oed@consensys.net)
EIP 1276 requires approval from one of (@eosclassicteam)
EIP 1462 requires approval from one of (mk@atlant.io, js@atlant.io)
EIP 1484 requires approval from one of (shanehampton1@gmail.com, andychorlian@gmail.com, anurag.angara@gmail.com, @NoahZinsmeister)
EIP 1812 requires approval from one of (@pelle)

axic · 2019-11-13T00:23:11Z

EIPS/eip-100.md

@@ -35,5 +35,5 @@ Changing the denominator from 10 to 9 ensures that the block time remains roughl

 ### References

-1. EIP 100 issue and discussion: https://github.com/ethereum/EIPs/issues/100
+1. EIP 100 issue and discussion: https://eips.ethereum.org/EIPS/eip-100


This seems to be a recursive declaration.

Maybe the solution here is that these self-links can go under the discussion-to metadata and I can take them out of the references like this.

(But if there is a specific comment that is being linked to I would keep that.)

What do you think about that?

I'm a bit confused, why is the original reference to the discussion forum a bad thing?

For most situations I think it makes sense to link to the web page (i.e. eips.ethereum.org/eip-number) but in this case where we're referencing the "issue and discussion" I feel like the GitHub link is most relevant, so that people can view & add to the discussion.

To clarify, this change is in the EIP-100 file, which is rendered on eips.ethereum.org/EIPS/eip-100 where it links back to itself. If that reference link is kept, it makes a lot of sense to keep it as a useful link.

axic · 2019-11-13T00:23:33Z

EIPS/eip-1261.md

@@ -364,7 +364,7 @@ Membership Verification Token ERC1261 -- a reference implementation
 1. ERC-20 Token Standard. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md
 1. ERC-165 Standard Interface Detection. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-165.md
 1. ERC-725/735 Claim Registry https://github.com/ethereum/EIPs/blob/master/EIPS/eip-725.md


These above could have been changed.

axic · 2019-11-13T00:24:49Z

EIPS/eip-170.md

@@ -25,5 +25,5 @@ Currently, there remains one slight quadratic vulnerability in Ethereum: when a

 ### References

-1. EIP-170 issue and discussion: https://github.com/ethereum/EIPs/issues/170
+1. EIP-170 issue and discussion: https://eips.ethereum.org/EIPS/eip-170


Recursive, again.

fulldecent · 2019-11-22T23:32:13Z

@axic Mostly motivated by ethereum/ethereum-org-website#343

fulldecent · 2019-12-01T22:44:04Z

@axic @samajammin In the interest of keeping this PR moving I have excluded the part which changes a "issue and discussion" link from eips.ethereum.org/EIPS/xxx to GitHub.com/ethereum/eips/issues/xxx

That is a whole topic which affects a few EIPs (and relates to SEO).

But to Always Be Merging, I'm hoping to get this PR done without that.

axic · 2019-12-01T22:50:31Z

EIPS/eip-1484.md

- [ERC-191 Signatures](https://github.com/ethereum/EIPs/issues/191)
- [ERC-725 Identities](https://github.com/ethereum/EIPs/issues/725)
+- [ERC-191 Signatures](https://eips.ethereum.org/EIPS/eip-191)
+- [ERC-725 Identities](https://eips.ethereum.org/EIPS/eip-725)
 - [ERC-1056 Identities](https://github.com/ethereum/EIPs/issues/1056)


This actually got merged: https://eips.ethereum.org/EIPS/eip-1056

axic · 2019-12-01T22:52:22Z

EIPS/eip-1462.md

@@ -22,9 +22,9 @@ The scope of this standard is being kept as narrow as possible to avoid restrict

 ## Motivation

-There are several security token standards that have been proposed recently. Examples include [ERC-1400/ERC-1411](https://github.com/ethereum/EIPs/issues/1411), also [ERC-1450](https://github.com/ethereum/EIPs/issues/1450). We have concerns about each of them, mostly because the scope of each of these EIPs contains many project-specific or market-specific details. Since many EIPs are coming from the respective backing companies, they capture many niche requirements that are excessive for a general case.
+There are several security token standards that have been proposed recently. Examples include [ERC-1400/ERC-1411](https://github.com/ethereum/EIPs/issues/1411), also [ERC-1450](https://eips.ethereum.org/EIPS/eip-1450). We have concerns about each of them, mostly because the scope of each of these EIPs contains many project-specific or market-specific details. Since many EIPs are coming from the respective backing companies, they capture many niche requirements that are excessive for a general case.


This is actually called "ERC-1400".

Got it. Here is a pure-play PR that fixes that #2414

axic · 2019-12-01T22:53:10Z

EIPS/eip-1261.md

@@ -364,7 +364,7 @@ Membership Verification Token ERC1261 -- a reference implementation
 1. ERC-20 Token Standard. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md


Maybe update this to eips.ethereum.org

You got it. Fixed at f87cc3a

axic · 2019-12-01T22:53:19Z

EIPS/eip-1261.md

@@ -364,7 +364,7 @@ Membership Verification Token ERC1261 -- a reference implementation
 1. ERC-20 Token Standard. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md
 1. ERC-165 Standard Interface Detection. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-165.md


And this too.

Fixed at f87cc3a

axic

This only updates links to the canonical eips.ethereum.org format. It is fine in my opinion.

Fix citation formats

1d6ca04

fulldecent mentioned this pull request Nov 12, 2019

Request: do SEO optimization for eips.ethereum.org ethereum/ethereum-org-website#343

Closed

chaitanyapotti approved these changes Nov 12, 2019

View reviewed changes

axic reviewed Nov 13, 2019

View reviewed changes

axic added the maintenance/editing label Nov 23, 2019

undo a link update

8ebb7ff

fulldecent added 2 commits December 1, 2019 17:44

Update eip-100.md

258b36d

Update eip-170.md

a9ece54

axic reviewed Dec 1, 2019

View reviewed changes

fulldecent and others added 4 commits December 1, 2019 17:56

Fix more links

f87cc3a

Merge branch 'master' into fix-citation-format

cc71548

Update eip-1484.md

d953f32

Update eip-137.md

db525ed

axic approved these changes Dec 2, 2019

View reviewed changes

axic merged commit 3aae3c9 into ethereum:master Dec 2, 2019

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020

Fix citation formats to use the canonical EIP URL (ethereum#2371)

73a569f

Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021

Fix citation formats to use the canonical EIP URL (ethereum#2371)

3c4889b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix citation formats [R4R] #2371

Fix citation formats [R4R] #2371

fulldecent commented Nov 12, 2019

eip-automerger commented Nov 12, 2019 •

edited

Loading

axic Nov 13, 2019

fulldecent Nov 19, 2019

axic Nov 22, 2019

samajammin Nov 23, 2019

axic Dec 1, 2019

axic Nov 13, 2019

axic Nov 13, 2019

fulldecent commented Nov 22, 2019

fulldecent commented Dec 1, 2019 •

edited

Loading

axic Dec 1, 2019

axic Dec 1, 2019

fulldecent Dec 1, 2019

axic Dec 1, 2019

fulldecent Dec 1, 2019

axic Dec 1, 2019

fulldecent Dec 1, 2019

axic left a comment

		@@ -364,7 +364,7 @@ Membership Verification Token ERC1261 -- a reference implementation
		1. ERC-20 Token Standard. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md

		@@ -364,7 +364,7 @@ Membership Verification Token ERC1261 -- a reference implementation
		1. ERC-20 Token Standard. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md
		1. ERC-165 Standard Interface Detection. https://github.com/ethereum/EIPs/blob/master/EIPS/eip-165.md

Fix citation formats [R4R] #2371

Fix citation formats [R4R] #2371

Conversation

fulldecent commented Nov 12, 2019

eip-automerger commented Nov 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fulldecent commented Nov 22, 2019

fulldecent commented Dec 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic left a comment

Choose a reason for hiding this comment

eip-automerger commented Nov 12, 2019 •

edited

Loading

fulldecent commented Dec 1, 2019 •

edited

Loading