EIP-210: Fixes for blockhash contracts #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue in the contract when executed from SYSTEM account at block 1. Then the number of the previous block is 0 and the contract executes the loop forever.
Fix fixes the issue in the blockhash contract where the negative value of the argument is not properly handled.
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Arachnid
approved these changes
May 18, 2018
|
That blocknum 1 issue is actually very important, because otherwise it'll produce very weird results in most test scenarios |
|
We still don't have any tests for the contract code itself, do we? |
|
We do, but for old version of the contract: #641. When migrating to new code I discovered this block 1 bug. |
|
Because these 2 bugs are quite obvious, I'd like to fix them first before progressing with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix blockhash contract for block number 1
This fixes the issue in the contract when executed from SYSTEM account at block 1. Then the number of the previous block is 0 and the contract executes the loop forever.
Correctly handle argument with negative value
Fix fixes the issue in the blockhash contract where the negative value of the argument is not properly handled.