Holocene: eip-1559 parameters in extraData #428
+26
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
requested review from
protolambda,
sebastianst and
ajsutton
as code owners
roberto-bayardo
force-pushed
the
holocene-execution-payload
branch
from
9b2a23d
to
4793842
Compare
tynes
reviewed
Oct 14, 2024
3 tasks
roberto-bayardo
force-pushed
the
holocene-execution-payload
branch
from
4793842
to
78552cd
Compare
roberto-bayardo
changed the title
|
As discussed in discord, updated spec to use extraData instead of nonce. |
roberto-bayardo
force-pushed
the
holocene-execution-payload
branch
3 times, most recently
from
8fd9747
to
edd510b
Compare
…Data instead of nonce.
roberto-bayardo
force-pushed
the
holocene-execution-payload
branch
from
edd510b
to
9aaaed6
Compare
protolambda
reviewed
Oct 16, 2024
Comment on lines
+75
to
+78
| - if `parent_header.extraData` is empty, the [canyon base fee parameter constants](../exec-engine.md#1559-parameters) | ||
| are used for the block's base fee parameters. | ||
| - if `parent_header.extraData` is non-empty with the version byte (first byte) value 0, the remaining 64 | ||
| bytes are used for the block's eip-1559 parameters. |
There was a problem hiding this comment.
Suggested change
| - if `parent_header.extraData` is empty, the [canyon base fee parameter constants](../exec-engine.md#1559-parameters) | |
| are used for the block's base fee parameters. | |
| - if `parent_header.extraData` is non-empty with the version byte (first byte) value 0, the remaining 64 | |
| bytes are used for the block's eip-1559 parameters. | |
| - if Holocene is not active in `parent_header.timestamp`, then `parent_header.extraData` may be set to anything valid in pre-Holocene context. The [canyon base fee parameter constants](../exec-engine.md#1559-parameters), or prior EIP-1559 constants are used for the block's base fee parameters. | |
| - While not set in regular pre-Holocene blocks, the `extraData` was set in the genesis block of some pre-Holocene chains, and other blocks with pre-Bedrock legacy content. It is thus important to check the hardfork before parsing the `extraData`. | |
| - if Holocene is active in `parent_header.timestamp`, then `parent_header.extraData` is non-empty, with the following encoding: | |
| - the first byte is set to `0`, used as version byte for the content. | |
| - the next 8 bytes are used to encode the 1559 params following the [`eip1559Params` | |
| encoding](#eip1559params-encoding). | |
| - the `extraData` ends there, at 9 bytes length. The `extraData` has a maximum capacity of 32 bytes (to fit in the L1 beacon-chain `extraData` data-type), and may be modified/extended in future versions. |
A hardfork should also not retro-actively apply constraints on prior blocks, like the parent-block.
The spec needs to call out that the transition block does not read the 1559 params from the more arbitrary pre-holocene block.
The previous spec rule would create weird behavior for the block right after genesis, if Holocene wasn't active then yet.
| | `GAS_LIMIT` | `uint8(2)` | `abi.encode(uint64 _gasLimit)` | Modifies the L2 gas limit | | ||
| | `UNSAFE_BLOCK_SIGNER` | `uint8(3)` | `abi.encode(address)` | Modifies the account that is authorized to progress the unsafe chain | | ||
| | `EIP_1559_PARAMS` | `uint8(4)` | `(uint256(_denominator) << 32) \| _elasticity` | Modifies the EIP-1559 denominator and elasticity | | ||
| | `EIP_1559_PARAMS` | `uint8(4)` | `abi.encode((uint256(_denominator) << 32) \| _elasticity)` | Modifies the EIP-1559 denominator and elasticity | |
There was a problem hiding this comment.
It may be worth clarifying that this is the format emitted by the SystemConfig. Not the same as the format in the block-header extraData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EIP-1559 parameters need to be in the ExecutionPayload, not just the PayloadAttributes, to allow geth to properly include the encoded parameters in the block header. So instead of using nonce, we use the extraData field which is already in the ExecutionPayload. This will also reserve nonce to be used for sub-second block times.