Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chain-mon): pnpm up --latest #6796

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

roninjin10
Copy link
Contributor

@roninjin10 roninjin10 commented Aug 15, 2023

  • run pnpm up --latest on chain-mon
  • keep ethers at v5 though
  • keep dateformat the same version because hardhat doesn't support esm and latest dateformat supports only esm

@roninjin10
Copy link
Contributor Author

roninjin10 commented Aug 15, 2023

@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from da88957 to ea9f8f4 Compare August 15, 2023 11:15
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from a2e799a to ac3c293 Compare August 15, 2023 11:19
@roninjin10 roninjin10 requested review from a team as code owners August 15, 2023 11:19
@roninjin10 roninjin10 requested review from clabby and nickbalestra and removed request for a team August 15, 2023 11:19
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from ea9f8f4 to 6b08229 Compare August 15, 2023 11:19
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from ac3c293 to 183013c Compare August 15, 2023 11:21
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from 6b08229 to aa1982e Compare August 15, 2023 11:21
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from 183013c to 8122ceb Compare August 15, 2023 11:33
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from aa1982e to 2d38de3 Compare August 15, 2023 11:33
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from 8122ceb to c99f1a6 Compare August 15, 2023 11:41
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from 2d38de3 to c0b4e32 Compare August 15, 2023 11:41
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from c99f1a6 to 35fbe48 Compare August 15, 2023 11:45
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from c0b4e32 to 81ad5b6 Compare August 15, 2023 11:45
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from 35fbe48 to b9eb437 Compare August 15, 2023 12:55
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from 81ad5b6 to 16d767d Compare August 15, 2023 12:55
@roninjin10 roninjin10 force-pushed the 08-15-chore_contracts-bedrock_pnpm_up_--latest branch from b9eb437 to 9eee2af Compare August 15, 2023 13:32
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch 2 times, most recently from 7b2ed8d to 149075f Compare August 15, 2023 13:45
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6796 (a196c63) into develop (c501244) will increase coverage by 0.06%.
Report is 24 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6796      +/-   ##
===========================================
+ Coverage    44.69%   44.76%   +0.06%     
===========================================
  Files          375      375              
  Lines        29469    29469              
  Branches      1692     1692              
===========================================
+ Hits         13172    13191      +19     
+ Misses       14853    14839      -14     
+ Partials      1444     1439       -5     
Flag Coverage Δ
bedrock-go-tests 47.77% <ø> (+0.08%) ⬆️
cannon-go-tests 64.18% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
sdk-next-tests 41.75% <ø> (ø)
sdk-tests 41.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Base automatically changed from 08-15-chore_contracts-bedrock_pnpm_up_--latest to develop August 15, 2023 14:59
@tynes
Copy link
Contributor

tynes commented Aug 15, 2023

Do we want changesets here?

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Aug 15, 2023
@roninjin10 roninjin10 force-pushed the 08-15-chore_chain-mon_pnpm_up_--latest branch from 149075f to a196c63 Compare August 15, 2023 20:22
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

This PR has been added to the merge queue, and will be merged soon.

@roninjin10 roninjin10 merged commit c8a94a5 into develop Aug 15, 2023
74 of 75 checks passed
@roninjin10 roninjin10 deleted the 08-15-chore_chain-mon_pnpm_up_--latest branch August 15, 2023 22:17
@mergify mergify bot removed the on-merge-train label Aug 15, 2023
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants