remove pythx #1733
Merged
remove pythx #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a side-effect here is dropping support for python 3.7. That seems fine. |
iamdefinitelyahuman
force-pushed
the
pythx
branch
2 times, most recently
from
ab35a2b
to
15fd690
Compare
iamdefinitelyahuman
force-pushed
the
pythx
branch
from
15fd690
to
6fd0597
Compare
|
This ended up getting bigger than planned.
Things are still breaking with 3.11 onward, I think from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove
brownie analyzeand thepythxlibrary as a dependency. MythX appears to be deprecated in favor of a newer tool, and hard pins onpythxare getting in the way when trying to bump other dependency versions.