Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: add "etcd_server_id" metric #9998

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 12, 2018

etcd_server_id{server_id="8e9e05c52164694d"} 1

Useful for automating membership change operations,
no need to run "endpoint status" or "member list"
command to get member IDs.

Also, useful for "etcd_network" metrics with "To/From" labels.

Will update http://etcd.readthedocs.io/en/latest and operation docs in following PRs.

ref. #9438

Namespace: "etcd",
Subsystem: "server",
Name: "id",
Help: "Server or member ID in hexadecimal format (1 for 'server_id' label with current ID)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyuho lgtm but, nit, suggest to keep the doc consistent, i.e. two sentences instead of brackets, similar to hasLeader, isLeader, currentVersion etc.

@xiang90
Copy link
Contributor

xiang90 commented Aug 12, 2018

lgtm

```
etcd_server_id{server_id="8e9e05c52164694d"} 1
```

Useful for automating membership change operations,
no need to run "endpoint status" or "member list"
command to get member IDs.

Also, useful for "etcd_network" metrics with "To/From" labels.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho merged commit f87b566 into etcd-io:master Aug 13, 2018
@gyuho gyuho deleted the member-id branch August 13, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants