Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustering.md: SRV records in DNS SAN for TLS #9886

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Conversation

zultron
Copy link
Contributor

@zultron zultron commented Jun 26, 2018

Using SRV discovery with TLS, the SRV record must be in the DNS SAN or clustering will fail.

This is a new requirement and may cause mysterious failures when upgrading from 3.1 to 3.2. I was only able to fix this in our configuration after reading through #8445; and now I understand the problem it's clear the docs have a hole here.

Using SRV discovery with TLS, the SRV record must be in the DNS SAN or clustering will fail.

This is a new requirement and may cause mysterious failures when upgrading from 3.1 to 3.2.  I was only able to fix this in our configuration after reading through etcd-io#8445; and now I understand the problem it's clear the docs have a hole here.
@codecov-io
Copy link

Codecov Report

Merging #9886 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9886      +/-   ##
==========================================
- Coverage    69.3%   69.16%   -0.15%     
==========================================
  Files         385      385              
  Lines       35703    35703              
==========================================
- Hits        24745    24694      -51     
- Misses       9165     9208      +43     
- Partials     1793     1801       +8
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
etcdserver/api/v3rpc/lease.go 63.63% <0%> (-10.23%) ⬇️
etcdserver/util.go 85% <0%> (-10%) ⬇️
pkg/fileutil/purge.go 65.9% <0%> (-6.82%) ⬇️
clientv3/namespace/watch.go 72.72% <0%> (-6.07%) ⬇️
pkg/transport/listener.go 58.67% <0%> (-4.09%) ⬇️
lease/leasehttp/http.go 56.61% <0%> (-2.95%) ⬇️
raft/progress.go 94.17% <0%> (-1.95%) ⬇️
etcdserver/v3_server.go 73.52% <0%> (-1.9%) ⬇️
raft/node.go 90.83% <0%> (-1.6%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6348a...b51d4a3. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho gyuho merged commit 61354ff into etcd-io:master Jun 26, 2018
@zultron zultron deleted the patch-1 branch June 26, 2018 20:56
zultron added a commit to zultron/freeipa-cloud-prov that referenced this pull request Jul 9, 2018
Upgrade to 3.2+ caused TLS connection failures because a new
requirement where the SRV record must be in the SSL cert's DNS SAN.

This also reverts the previous commit, "Back etcd3 version down to
3.1.5", and the default etcd version (3.3.3 at this time) is loaded.

This was undocumented, so I filed a PR:

etcd-io/etcd#9886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants