Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace grpc-gateway endpoint with /v3 #9298

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Feb 8, 2018

This PR replaces the current /v3beta with the stable /v3 API. Currently, support for /v3beta is maintained for one minor iteration and will remove completely as of 3.5. This can be removed now but as we offered the convenience with the last bump I kept it in while completely removing /v3alpha.

I will attempt to improve e2e test coverage in a separate PR.

ref: #9189

@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9c6d930). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9298   +/-   ##
=========================================
  Coverage          ?   75.58%           
=========================================
  Files             ?      365           
  Lines             ?    30695           
  Branches          ?        0           
=========================================
  Hits              ?    23202           
  Misses            ?     5874           
  Partials          ?     1619
Impacted Files Coverage Δ
embed/serve.go 69.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6d930...488ee99. Read the comment docs.

@gyuho
Copy link
Contributor

gyuho commented Feb 8, 2018

lgtm. Defer to @xiang90
Thanks

@hexfusion
Copy link
Contributor Author

Well since I am here I am going to refactor the curl testing and probably break it out over a few different files.

@xiang90
Copy link
Contributor

xiang90 commented Feb 10, 2018

sgtm

@hexfusion
Copy link
Contributor Author

hexfusion commented Feb 11, 2018

@xiang90 PTAL, if this seems reasonable I would like to get this merged and add the breakout test files in a new commit as this is quite large already.

@hexfusion
Copy link
Contributor Author

@xiang90 kind ping :)

@xiang90
Copy link
Contributor

xiang90 commented Feb 13, 2018

@hexfusion i am fine with this large commit.

@hexfusion hexfusion merged commit fcd71b4 into etcd-io:master Feb 13, 2018
@hexfusion hexfusion deleted the v3 branch February 13, 2018 22:18
@hexfusion
Copy link
Contributor Author

thank you

hexfusion added a commit to hexfusion/etcd that referenced this pull request Feb 13, 2018
gyuho added a commit that referenced this pull request Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants