Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: allow user-provided watch ID to mvcc #9065

Merged
merged 7 commits into from
Jan 5, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Dec 22, 2017

Smaller changes in server-side from #9015.
Plus, clientv3 change to handle non -1 watch ID (but Canceled==true).

Watch ID is only configurable to mvcc/v3rpc for the use of other language client bindings.
Go clientv3 will still auto-generate watch IDs.

Cherry-pick #8662.
Fix #7036.

@gyuho
Copy link
Contributor Author

gyuho commented Dec 22, 2017

@xiang90 PTAL.

Added clientv3 watch response cancel field check (in addition to watch id == -1 check) for forward compatibility. watch id == -1 is still there for backward compatibility (v3.4 client against v3.3 servers).

gyuho and others added 6 commits December 31, 2017 13:20
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
This allows for watchers to be created concurrently
without needing potentially complex and latency-adding
queuing on the client.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@fdec12c). Click here to learn what that means.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9065   +/-   ##
=========================================
  Coverage          ?   76.08%           
=========================================
  Files             ?      359           
  Lines             ?    29959           
  Branches          ?        0           
=========================================
  Hits              ?    22794           
  Misses            ?     5588           
  Partials          ?     1577
Impacted Files Coverage Δ
clientv3/watch.go 95.34% <0%> (ø)
mvcc/watcher.go 100% <100%> (ø)
etcdserver/api/v3rpc/watch.go 89.59% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdec12c...10522f8. Read the comment docs.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@xiang90
Copy link
Contributor

xiang90 commented Jan 5, 2018

lgtm

@gyuho gyuho merged commit 6546483 into etcd-io:master Jan 5, 2018
@xiang90
Copy link
Contributor

xiang90 commented Jan 5, 2018

@gyuho you might want to check with @fanminshi to make sure jetcd is not affected.

@gyuho gyuho deleted the watch-id-2 branch January 5, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants