etcdserver: initialize raftNode with constructor #7757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
force-pushed
the
fix-speedy-close
branch
from
d3127c3
to
17ad654
Compare
xiang90
reviewed
Apr 18, 2017
| @@ -94,14 +94,7 @@ type raftNode struct { | |||
| term uint64 | |||
| lead uint64 | |||
|
|
|||
| mu sync.Mutex | |||
| // last lead elected time | |||
| lt time.Time | |||
There was a problem hiding this comment.
why do we need to move this variable around in this pr?
There was a problem hiding this comment.
Copying the structure around copies the mutex which causes the static checks to complain.
heyitsanthony
force-pushed
the
fix-speedy-close
branch
from
17ad654
to
714b48a
Compare
raftNode was being initialized in start(), which was causing hangs when trying to stop the etcd server since the stop channel would not be initialized in time for the stop call. Instead, setup non-configurable bits in a constructor. Fixes etcd-io#7668
Codecov Report
@@ Coverage Diff @@
## master #7757 +/- ##
=========================================
Coverage ? 75.94%
=========================================
Files ? 331
Lines ? 26062
Branches ? 0
=========================================
Hits ? 19794
Misses ? 4847
Partials ? 1421
Continue to review full report at Codecov.
|
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raftNode was being initialized in start(), which was causing
hangs when trying to stop the etcd server since the stop channel
would not be initialized in time for the stop call. Instead,
setup non-configurable bits in a constructor.
Fixes #7668