etcdctl: remaining errors.Is conversions

[redwrasse]

Remaining errors.Is conversions for the etcdctl module, as part of #18576.

[k8s-ci-robot]

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (6ea81c1) to head (cd567e7).

❗ Current head cd567e7 differs from pull request most recent head 0a355d3

Please upload reports for the commit 0a355d3 to get more accurate results.

Files with missing lines	Patch %	Lines
etcdctl/ctlv3/command/auth_command.go	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
etcdctl/ctlv3/command/auth_command.go	0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18615      +/-   ##
==========================================
- Coverage   68.78%   68.75%   -0.03%     
==========================================
  Files         420      420              
  Lines       35519    35519              
==========================================
- Hits        24431    24422       -9     
- Misses       9662     9669       +7     
- Partials     1426     1428       +2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea81c1...0a355d3. Read the comment docs.

[jmhbnz]

/ok-to-test

LGTM on green, thanks @redwrasse

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, redwrasse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

Hi @redwrasse, Thanks for the pull request. I see this has already been merged. I couldn't review it before, but did we miss ctlv3/command/ep_command.go:140?

etcd/etcdctl/ctlv3/command/ep_command.go

Line 140 in 0a355d3

if err == nil || err == rpctypes.ErrPermissionDenied {

[redwrasse]

Yes looks like we did, my fault. Should we open a PR for this, or wait to see if there's a few more stragglers?

[ahrtr]

etcd/etcdctl/ctlv3/command/ep_command.go

Please raise a separate PR, thanks

[redwrasse]

Opened a PR #18625