Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure commits are signed in scripts/release.sh #18592

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Sep 15, 2024

Address #18581 in main.

We need to also backport it to release-3.5.

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz jmhbnz changed the title Ensure commits are signed in scripts/release.sh Ensure commits are signed in scripts/release.sh Sep 15, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (6c1fe4a) to head (0c2f47d).

Current head 0c2f47d differs from pull request most recent head 7e8e0bf

Please upload reports for the commit 7e8e0bf to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18592      +/-   ##
==========================================
- Coverage   68.83%   68.79%   -0.05%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
- Hits        24419    24404      -15     
- Misses       9636     9646      +10     
- Partials     1419     1424       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1fe4a...7e8e0bf. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jmhbnz

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 7f399ee into etcd-io:main Sep 16, 2024
47 checks passed
@jmhbnz
Copy link
Member Author

jmhbnz commented Sep 17, 2024

/cherrypick release-3.5

@k8s-infra-cherrypick-robot

@jmhbnz: new pull request created: #18599

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants