Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Use random scheduler #15452

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

serathius
Copy link
Member

@serathius serathius commented Mar 13, 2023

Backporting #15431 to release-3.5

cc @ahrtr @ptabor
Phase 1 of #15402 (comment)

@serathius serathius changed the title Watch random scheduler 3.5 UseWatch random scheduler 3.5 Mar 13, 2023
@serathius serathius changed the title UseWatch random scheduler 3.5 [3.5] Use random scheduler Watch Mar 13, 2023
@serathius serathius force-pushed the watch-random-scheduler-3.5 branch 2 times, most recently from a0b2395 to 7f43942 Compare March 13, 2023 15:55
Comment on lines +342 to +344
if cfg.WatchProcessNotifyInterval != 0 {
args = append(args, "--experimental-watch-progress-notify-interval", cfg.WatchProcessNotifyInterval.String())
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: this seems not in the original PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added a commit for backport that adds missing feature in e2e testing framework

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please rebase this PR and merge it after the test is green.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
… when sharing the same connection

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
…h starvation

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius merged commit 3a63da9 into etcd-io:release-3.5 Mar 14, 2023
@serathius serathius changed the title [3.5] Use random scheduler Watch [3.5] Use random scheduler Mar 30, 2023
@serathius serathius deleted the watch-random-scheduler-3.5 branch June 15, 2023 20:38
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants