[3.5] clientv3: revert the client side change in 14547 #14995
Conversation
In order to fix etcd-io#12385, PR etcd-io#14322 introduced a change in which the client side may retry based on the error message returned from server side. This is not good, as it's too fragile and it's also changed the protocol between client and server. Please see the discussion in kubernetes/kubernetes#114403 Note: The issue etcd-io#12385 only happens when auth is enabled, and client side reuse the same client to watch. So we decided to rollback the change on 3.5, reasons: 1.K8s doesn't enable auth at all. It has no any impact on K8s. 2.It's very easy for client application to workaround the issue. The client just needs to create a new client each time before watching. Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
Reference: #14547 |
|
yes please. thanks! |
|
Thanks @mitake for the quick review. |
|
@ahrtr Sorry but I just want to confirm, as we are seeing the same issue in our cluster where we enabled auth. Is the correct way to fix this by instead creating a new client for every Watch call made? Or I guess we can upgrade to 3.5.6 which does have the fix? |
Yes, it should can workaround this issue.
3.5.6 has this fix, but we reverted the change in 3.5.7( to be released soon). We are working on a more formal solution in #15058. I am not sure whether we will backport the fix to 3.5 eventually for now. If lots of people request backporting, we can do it. |
|
Awesome thanks so much 👍 |
ahrtr
changed the title
clientv3: revert the client side change in 14547
In order to fix #12385, PR #14322 introduced a change in which the client side may retry based on the error message returned from server side.
This is not good, as it's too fragile and it's also changed the protocol between client and server. Please see the discussion in kubernetes/kubernetes#114403
Note: The issue #12385 only happens when auth is enabled, and client side reuse the same client to watch.
So we decided to rollback the change on 3.5, reasons:
The client just needs to create a new client each time before watching.
Signed-off-by: Benjamin Wang wachao@vmware.com
cc @mitake @ptabor @serathius @spzala @liggitt @dims @lavalamp @deads2k
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.