etcdserver: Move version monitor logic to separate module #13132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ptabor |
serathius
force-pushed
the
refactor-monitor
branch
from
7d09924
to
13212f3
Compare
|
cc @lilic |
xiang90
reviewed
Jun 22, 2021
|
LGTM |
serathius
force-pushed
the
refactor-monitor
branch
6 times, most recently
from
f7d9c60
to
c623991
Compare
lilic
approved these changes
Jun 23, 2021
server/etcdserver/server.go
Outdated
| var _ serverversion.VersionStorage = (*serverVersionAdapter)(nil) | ||
|
|
||
| func (s *serverVersionAdapter) UpdateClusterVersion(version string) { | ||
| // TODO switch to updateClusterVersionV3 in 3.6 |
There was a problem hiding this comment.
Since it's 3.6 now should we do this already? I am fine with a separate PR as well.
There was a problem hiding this comment.
Separate :P, lets make such changes in organized bulk way, instead of trickles.
serathius
force-pushed
the
refactor-monitor
branch
from
c623991
to
823f85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on version downgrade I noticed that logic responsible for managing versions is spread all over etcdserver module. As logic is spread around it was never tested together leading to errors like described in #11716 (comment) where cluster version monitor didn't work well with downgrade monitor.
To ensure that downgrades are well tested and working correctly we need one place to all logic together. This PR is a first step in this direction. It moves downgrade and version monitor logic to a separate module. We define an interface over etcdServer that will allow this logic to manipulate version, but also stub backend and member versions in future so we can simulate step by step upgrade process. To avoid exposing version change logic publicly I have created an adapter struct that implements the interface, but is not available outside of module.