Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save raftpb.ConfState in the backend. #12962

Merged
merged 2 commits into from
May 13, 2021
Merged

Save raftpb.ConfState in the backend. #12962

merged 2 commits into from
May 13, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented May 13, 2021 •
edited
Loading

This makes (bbolt) backend a full feature snapshot in terms of WAL/raft,
i.e. carries:

Benefits:

  • Backend will be a sufficient point in time definition sufficient to
    start replaying WAL. We have applied_index & confState in consistent
    state.
  • In case of emergency a backend state can be used for recovery

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

@ptabor
Save raftpb.ConfState in the backend.
865df75 
This makes (bbolt) backend a full feature snapshot in term of WAL/raft,
i.e. carries:
  - commit : (applied_index)
  - confState

Benefits:
  - Backend will be a sufficient point in time definition sufficient to
start replaying WAL. We have applied_index & confState in consistent
state.
  - In case of emergency a backend state can be used for recovery
@ptabor ptabor force-pushed the 20210513-write-conf-state branch from 37c7ceb to 865df75 Compare May 13, 2021 12:30
@gyuho
Copy link
Contributor

gyuho commented May 13, 2021 •
edited by ptabor
Loading

commit : (applied_index)

Do you remember which PR made this change?

gyuho
gyuho approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can we add this to our changelog?

@ptabor
Copy link
Contributor Author

ptabor commented May 13, 2021

commit : (applied_index)

Do you remember which PR made this change?

Applied index is forever (from my perspectice).

In 4d4c84e I made confState be part of WAL Snapshot (as opposed to be part of StoreV2 content only): #12735

@ptabor
Copy link
Contributor Author

ptabor commented May 13, 2021

lgtm! can we add this to our changelog?

done

@ptabor ptabor merged commit e44fb40 into etcd-io:main May 13, 2021
@ptabor ptabor deleted the 20210513-write-conf-state branch May 13, 2021 17:22
@ptabor
Copy link
Contributor Author

ptabor commented May 14, 2021

FTR: Main goal: #12913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptabor @gyuho