etcdserver/util.go: reduce memory when logging range requests #12871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. We have a few other places we call Can we check others as well? |
chaochn47
force-pushed
the
20210416-reduce-memory-when-logging-read-requests
branch
from
212a278
to
7e70ef8
Compare
chaochn47
force-pushed
the
20210416-reduce-memory-when-logging-read-requests
branch
from
7e70ef8
to
4b8969a
Compare
gyuho
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have multiple excessive large range requests landing on etcd server, the response size warn loggging calling
proto.Size()takes 30% of memory allocation, it can be avoided by non-marshal implementationrangeResponse.Size()and give etcd server more headroom to request memory allocation.Fixes #12835