Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded server should not mess global loggers (by default) #12861

Merged
merged 4 commits into from
Apr 15, 2021

Commits on Apr 14, 2021

  1. Configuration menu
    Copy the full SHA
    eafbc8c View commit details
    Browse the repository at this point in the history
  2. Give control to Embedded servers whether they override global loggers

    So far each instance of embed server was overriding the grpc loggers and zap.global loggers.
    It's counter intutitive that last created Embedded server was 'wining' and more-over it was breaking grpc expectation to change it "only" before the grpc stack is being used.
    
    This PR introduces explicit call: `embed.Config::SetupGlobalLoggers()`, that changes the loggers where requested. The call is used by etcd main binary.
    
    The immediate benefit from this change is reduction of  test flakiness, as there were flakes due to not a proper logger being used across tests.
    ptabor committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    d72f7ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fad6391 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Configuration menu
    Copy the full SHA
    b47c5fc View commit details
    Browse the repository at this point in the history