*: add self-signed-cert-validity flag to fix cert expire issue #12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangcong
force-pushed
the
fix-cert-exp
branch
from
981899d
to
33a6e5d
Compare
gyuho
reviewed
Oct 29, 2020
gyuho
reviewed
Oct 29, 2020
gyuho
reviewed
Oct 29, 2020
gyuho
reviewed
Oct 29, 2020
|
Just minor nits. Can we also update CHANGELOG? Otherwise LGTM. |
tangcong
force-pushed
the
fix-cert-exp
branch
3 times, most recently
from
d9b74fd
to
4267437
Compare
tangcong
force-pushed
the
fix-cert-exp
branch
from
4267437
to
0b4b5d8
Compare
|
updated. thanks. @gyuho |
gyuho
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #12427