Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: add ConfChangeAddLearnerNode to the list of config changes #12288

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

galal-hussein
Copy link
Contributor

To fix a panic that happens when force-new-cluster flag is passed to
etcd node if the cluster had learner nodes added from before

Fixes #12285

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a nit: could you also update line 617: s/two/three

@jingyih
Copy link
Contributor

jingyih commented Sep 14, 2020

We will need to backport this to 3.4 branch.

To fix a panic that happens when trying to get ids of etcd members in
force new cluster mode, the issue happen if the cluster previously had
etcd learner nodes added to the cluster

Fixes etcd-io#12285
@galal-hussein
Copy link
Contributor Author

galal-hussein commented Sep 14, 2020

@jingyih thanks very much, fixed the nit and added the backport PR #12299

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @galal-hussein

@jingyih jingyih merged commit 3752333 into etcd-io:master Sep 15, 2020
@jingyih
Copy link
Contributor

jingyih commented Sep 15, 2020

For the reference, this PR is backported to release-3.4 via #12299.

spzala added a commit that referenced this pull request Sep 16, 2020
absolute8511 added a commit to youzan/ZanRedisDB that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Force new cluster causes etcd to panic when learner members are added
3 participants