Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11452 #12187 on release 3.4 #12189

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Jul 30, 2020

#11452: clientv3: log warning in case of error sending request
#12187: clientv3: remove excessive watch cancel logging

@jingyih
Copy link
Contributor Author

jingyih commented Jul 30, 2020

This cherrypick is causing the following test to timeout.

=== RUN   TestV3ElectionCampaign
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@jingyih jingyih force-pushed the automated-cherry-pick-of-#11452-#12187-upstream-release-3.4 branch from 1cc74f1 to 6fcab5a Compare August 13, 2020 05:53
@jingyih
Copy link
Contributor Author

jingyih commented Aug 13, 2020

It turns out that we removed all nil checking for logger in master branch, but not in 3.4 branch. Just added the nil checking back to this backport.

@jingyih
Copy link
Contributor Author

jingyih commented Aug 13, 2020

@gyuho PTAL. We need a new 3.4 patch release to be picked up by k8s v.119.
xref: kubernetes/kubernetes#93450

@gyuho gyuho merged commit 8a4afdb into etcd-io:release-3.4 Aug 14, 2020
@gyuho
Copy link
Contributor

gyuho commented Aug 14, 2020

ack, will cut a patch release soon

@jingyih
Copy link
Contributor Author

jingyih commented Aug 14, 2020

@gyuho Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants