Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver:set FDUsage ticker to 10 minute from 5 seconds. #11986

Merged
merged 1 commit into from
Jun 16, 2020
Merged

etcdserver:set FDUsage ticker to 10 minute from 5 seconds. #11986

merged 1 commit into from
Jun 16, 2020

Conversation

cfc4n
Copy link
Contributor

@cfc4n cfc4n commented Jun 7, 2020

Fixes #11969

@cfc4n cfc4n changed the title etcdserver:FDUsage set ticker from 5 seconds to 1 hour. etcdserver:set FDUsage ticker to 1 hour from 5 seconds. Jun 7, 2020
@cfc4n cfc4n mentioned this pull request Jun 7, 2020
Closed
xiang90
xiang90 reviewed Jun 10, 2020
View reviewed changes
etcdserver/metrics.go Outdated Show resolved Hide resolved
@cfc4n cfc4n changed the title etcdserver:set FDUsage ticker to 1 hour from 5 seconds. etcdserver:set FDUsage ticker to 10 minute from 5 seconds. Jun 11, 2020
@cfc4n cfc4n mentioned this pull request Jun 11, 2020
Merged
@cfc4n cfc4n requested a review from xiang90 June 15, 2020 08:22
@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 15, 2020

PTAL ,thanks @spzala

@gyuho
Copy link
Contributor

gyuho commented Jun 15, 2020

@cfc4n Can you inline comment this change in addition to linking the github issue? otherwise, lgtm :)

@cfc4n
etcdserver:FDUsage set ticker to 10 minute from 5 seconds.
144beba 
This ticker will check File Descriptor Requirements ,and count all fds in used.
And recorded some logs when in used >= limit/5*4. Just recorded message.
If fds was more than 10K,It's low performance due to FDUsage() works.
So need to increase it.

see #11969 for more detail.
@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 16, 2020

@cfc4n Can you inline comment this change in addition to linking the github issue? otherwise, lgtm :)

Done, Thanks for review.

@gyuho
Copy link
Contributor

gyuho commented Jun 16, 2020

lgtm thx

@gyuho gyuho merged commit 8720f98 into etcd-io:master Jun 16, 2020
gyuho added a commit that referenced this pull request Jun 22, 2020
@gyuho
Merge pull request #12001 from cfc4n/master
6ec5d5f 
CHANGELOG: update for PR #11980 ,  #11986 ,  # 11987 ,
This was referenced Jun 24, 2020
Closed
Merged
Merged
gyuho added a commit that referenced this pull request Jun 25, 2020
@gyuho
Merge pull request #12064 from cfc4n/automated-cherry-pick-of-#11986-…
45192cf 
…upstream-release-3.4

Automated cherry pick of #11986
gyuho added a commit that referenced this pull request Jun 25, 2020
@gyuho
Merge pull request #12063 from cfc4n/automated-cherry-pick-of-#11986-…
829f484 
…upstream-release-3.3

Automated cherry pick of #11986
@cfc4n cfc4n deleted the fdusage-limit branch June 28, 2020 04:12
@hexfusion hexfusion mentioned this pull request Feb 25, 2021
Merged
@dims
Copy link
Contributor

dims commented Sep 3, 2021

@cfc4n @xiang90 @gyuho please see the change made in tailscale for the same problem - tailscale/tailscale#2785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiang90 xiang90 Awaiting requested review from xiang90

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

etcdserver: runtime.FDUsage() function high CPU usage, create large numbers of objects
4 participants
@cfc4n @gyuho @dims @xiang90