*: make sure snapshot save downloads SHA256 checksum #11896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11896 +/- ##
==========================================
+ Coverage 65.65% 66.23% +0.57%
==========================================
Files 403 403
Lines 37145 37160 +15
==========================================
+ Hits 24388 24613 +225
+ Misses 11249 11034 -215
- Partials 1508 1513 +5
Continue to review full report at Codecov.
|
wongma7
approved these changes
May 15, 2020
| br += int64(n) | ||
| sent += int64(n) | ||
|
|
||
| // if total is x * snapshotSendBufferSize. it is possible that |
clientv3/maintenance.go
Outdated
| // No, server sends EOF with an empty response | ||
| // after it sends SHA digest at the end | ||
| // TODO: investigate why this had happened... | ||
| if resp == nil { |
There was a problem hiding this comment.
If we think the code should be unreachable, is it possible to log a warning here?
There was a problem hiding this comment.
it should be unreachable because if the server sends EOF it will get consumed by pw.CloseWithError(err) which treats EOF as a non-issue i.e. pw.CloseWithError(io.EOF) is basically the same as pw.Close()
gyuho
force-pushed
the
snapshot
branch
2 times, most recently
from
c8e7d9c
to
eac0b25
Compare
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
I've seen some cases SHA blobs are missing (still investigating). Adding a check to make sure snapshot save always downloads hash digests for integrity checks. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 17, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 17, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 18, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 18, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 18, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 18, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
May 18, 2020
ref. #11896 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
renormalize
added a commit
to renormalize/etcd-client
that referenced
this pull request
Aug 16, 2024
* Snapshot hash is sent after the first occurence of `r.remaining_bytes() == 0`. See etcd-io/etcd#11896 for more information. * If the snapshot operation is performed as shown in the example previously, restarting the etcd on the stored data from this won't succeed unless etcd is started with `--skip-hash-check=true`. This isn't necessary anymore since the final `msg.message().await` fetches the snapshot hash information.
renormalize
added a commit
to renormalize/etcd-client
that referenced
this pull request
Aug 16, 2024
* Snapshot hash is sent after the first occurance of `r.remaining_bytes() == 0`. See etcd-io/etcd#11896 for more information. * If the snapshot operation is performed as shown in the example previously, restarting the etcd on the stored data from this won't succeed unless etcd is started with `--skip-hash-check=true`. This isn't necessary anymore since the final `msg.message().await` fetches the snapshot hash information.
davidli2010
pushed a commit
to renormalize/etcd-client
that referenced
this pull request
Aug 18, 2024
* Snapshot hash is sent after the first occurance of `r.remaining_bytes() == 0`. See etcd-io/etcd#11896 for more information. * If the snapshot operation is performed as shown in the example previously, restarting the etcd on the stored data from this won't succeed unless etcd is started with `--skip-hash-check=true`. This isn't necessary anymore since the final `msg.message().await` fetches the snapshot hash information.
davidli2010
pushed a commit
to etcdv3/etcd-client
that referenced
this pull request
Aug 18, 2024
…n. (#83) * Snapshot hash is sent after the first occurance of `r.remaining_bytes() == 0`. See etcd-io/etcd#11896 for more information. * If the snapshot operation is performed as shown in the example previously, restarting the etcd on the stored data from this won't succeed unless etcd is started with `--skip-hash-check=true`. This isn't necessary anymore since the final `msg.message().await` fetches the snapshot hash information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some cases where hash was missing from snapshots (still investigating).
This makes sure
clientv3/snapshotdownloads checksum from the server.