Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: use Go 1.14 for CI #11864

Merged
merged 10 commits into from
May 12, 2020
Merged

*: use Go 1.14 for CI #11864

merged 10 commits into from
May 12, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 10, 2020

gyuho added 8 commits May 9, 2020 23:34
@gyuho
*: use Go 1.14 for CI
628bd29 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
test: ignore vendor directory in govet test
b6ea32e 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
test: test '-mod=mod'
027c26a 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
test: set mod flags for bom test
e94201c 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
pkg/tlsutil: add "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256" to s…
b34c0c5 
…upport cipher suite

pkg/tlsutil: support TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
test: add "mod" to build tests
6874b9a 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
travis: set "-mod=mod"
b79abb6 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
functional: add "-mod=mod" flags
0a0c27a 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented May 11, 2020

/cc @xiang90 @spzala @jingyih

spzala
spzala reviewed May 11, 2020
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyuho awesome, thanks!
lgtm - and couple of points that can be done separately. First is changelog and second should we update the docker-local-agent.sh and docker-local-tester.sh as well? Thanks!

gyuho added 2 commits May 11, 2020 18:05
@gyuho
functional/scripts: update default Go version
60ce7bc 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
CHANGELOG-3.5: update
1156982 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented May 12, 2020

@spzala Updated CHANGELOGs and docker scripts.

@gyuho gyuho merged commit 2ecf268 into etcd-io:master May 12, 2020
@gyuho gyuho deleted the go1.14 branch May 12, 2020 01:08
@spzala
Copy link
Member

spzala commented May 12, 2020

Awesome! Thanks @gyuho

@spzala spzala mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @spzala