Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11735 on release-3.4 #11811

Conversation

wswcfan
Copy link
Contributor

@wswcfan wswcfan commented Apr 25, 2020

Cherry pick of #11735 on release-3.4.

#11735: auth: optimize lock scope for CheckPassword

to improve authentication performance in concurrent scenarios when enable auth and using authentication based password
@wswcfan wswcfan changed the title Automated cherry pick of #11735 Automated cherry pick of #11735 on release-3.4 Apr 25, 2020
@gyuho gyuho force-pushed the release-3.4 branch 4 times, most recently from 72d52a7 to 9bad82f Compare May 18, 2020 00:38
@tangcong
Copy link
Contributor

this pr improves checkPassword( Authenticate interface) performance by more than 10 times. could we merge it into release-3.4? thanks. @gyuho

@gyuho gyuho merged commit 609e844 into etcd-io:release-3.4 May 20, 2020
@gyuho
Copy link
Contributor

gyuho commented May 20, 2020

@tangcong @wswcfan can you help backport this to 3.4? Then, we can release a new 3.4.

@tangcong
Copy link
Contributor

it is also backported to 3.4, do you mean also backport it to 3.3? @gyuho

@gyuho
Copy link
Contributor

gyuho commented May 20, 2020

Oh, I misread the branch name. Never mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants