Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG-3.5: update from #11548 and #11358 #11791

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

nirmannarang
Copy link
Contributor

Signed-off-by: Nirman Narang narang@us.ibm.com

Adding update from PRs #11548 and #11358 to CHANGELOG-3.5.md.

Signed-off-by: Nirman Narang <narang@us.ibm.com>
@codecov-io
Copy link

Codecov Report

Merging #11791 into master will decrease coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11791      +/-   ##
==========================================
- Coverage   66.65%   65.74%   -0.91%     
==========================================
  Files         403      403              
  Lines       36881    36881              
==========================================
- Hits        24582    24247     -335     
- Misses      10811    11133     +322     
- Partials     1488     1501      +13     
Impacted Files Coverage Δ
clientv3/ordering/kv.go 16.17% <0.00%> (-69.12%) ⬇️
auth/options.go 35.00% <0.00%> (-57.50%) ⬇️
auth/store.go 52.94% <0.00%> (-25.43%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
pkg/netutil/netutil.go 61.47% <0.00%> (-7.38%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
clientv3/concurrency/mutex.go 61.64% <0.00%> (-5.48%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0.00%> (-4.77%) ⬇️
pkg/adt/interval_tree.go 82.70% <0.00%> (-4.52%) ⬇️
clientv3/leasing/cache.go 87.22% <0.00%> (-4.45%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f5fb2...38ef3da. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spzala
Copy link
Member

spzala commented Apr 22, 2020

Merging.. /cc @gyuho

@spzala spzala merged commit 6aea6ed into etcd-io:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants