Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: remove capnslog #11614

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Feb 12, 2020

Remove dependency of capnslog in proxy package.

Related: #11426

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #11614 into master will decrease coverage by 0.33%.
The diff coverage is 36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11614      +/-   ##
==========================================
- Coverage   66.56%   66.22%   -0.34%     
==========================================
  Files         403      403              
  Lines       36630    36661      +31     
==========================================
- Hits        24381    24277     -104     
- Misses      10768    10894     +126     
- Partials     1481     1490       +9
Impacted Files Coverage Δ
proxy/tcpproxy/userspace.go 57.02% <ø> (+2.76%) ⬆️
etcdmain/grpc_proxy.go 15.56% <0%> (ø) ⬆️
etcdmain/etcd.go 0% <0%> (ø) ⬆️
proxy/httpproxy/proxy.go 46.51% <0%> (-3.49%) ⬇️
integration/cluster_proxy.go 100% <100%> (ø) ⬆️
proxy/httpproxy/reverse.go 63.02% <25.92%> (-7.98%) ⬇️
proxy/httpproxy/director.go 68.29% <28.57%> (-11.71%) ⬇️
proxy/grpcproxy/cluster.go 51.02% <50%> (-0.56%) ⬇️
proxy/grpcproxy/register.go 82.5% <90.9%> (+13.05%) ⬆️
client/keys.go 56.78% <0%> (-34.68%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f2794...81f00b0. Read the comment docs.

@@ -75,10 +75,14 @@ func (p *reverseProxy) ServeHTTP(rw http.ResponseWriter, clientreq *http.Request
proxybody, err = ioutil.ReadAll(clientreq.Body)
if err != nil {
msg := fmt.Sprintf("failed to read request body: %v", err)
plog.Println(msg)
p.lg.Info(msg, zap.Error(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingyih thanks, lgtm except one comment here that, the msg already has err so we shouldn't repeat it, and just use p.lg.Info(msg) or remove err from the msg? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Addressed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jingyih

@xiang90 xiang90 merged commit bb29615 into etcd-io:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants