Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: simplify grpc dialer usage. #11574

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

YoyinZyc
Copy link
Contributor

@YoyinZyc YoyinZyc commented Jan 30, 2020

fix #11519
verified by tests under tests/docker-dns, tests/dorker-dns-srv, tests/docker-static-ip
@jpbetz @gyuho

@codecov-io
Copy link

Codecov Report

Merging #11574 into master will decrease coverage by 0.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #11574     +/-   ##
=========================================
- Coverage   64.57%   63.78%   -0.8%     
=========================================
  Files         403      403             
  Lines       38097    38074     -23     
=========================================
- Hits        24600    24284    -316     
- Misses      11851    12130    +279     
- Partials     1646     1660     +14
Impacted Files Coverage Δ
clientv3/client.go 71.67% <ø> (-2.75%) ⬇️
clientv3/balancer/resolver/endpoint/endpoint.go 81.89% <100%> (-2.46%) ⬇️
clientv3/credentials/credentials.go 84.61% <100%> (+1%) ⬆️
clientv3/ordering/kv.go 33.82% <0%> (-51.48%) ⬇️
auth/simple_token.go 63.41% <0%> (-23.58%) ⬇️
client/keys.go 68.34% <0%> (-23.12%) ⬇️
auth/store.go 51.02% <0%> (-17.35%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
clientv3/concurrency/mutex.go 62.16% <0%> (-5.41%) ⬇️
etcdserver/api/v3rpc/lease.go 64.77% <0%> (-4.55%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f15ca...b90d801. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Jan 31, 2020

There are a few exposed public method removed. Will this affect client API backward compatibility?

@YoyinZyc
Copy link
Contributor Author

There are a few exposed public method removed. Will this affect client API backward compatibility?

Most of them are the workaround from #11184. We can safely remove them after bumping into latest gRPC.

@gyuho
Copy link
Contributor

gyuho commented Jan 31, 2020

lgtm, can we highlight this fix in CHANGELOG 3.5? thx

@YoyinZyc
Copy link
Contributor Author

lgtm, can we highlight this fix in CHANGELOG 3.5? thx

Sure. Will do after merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Simplify grpc dialer usage in clientv3
4 participants