Issue 11383: make mirror accept auth credentials

[schlitzered]

Hi,

the request solves the issue in the title.

two new arguments have been introduced for the make-mirror subcommand:
--dest-user and --dest-password.

both work similar to the --user and --password global arguments.

--dest-user can either be "$USERNAM:$PASSWORD
or "$PASWORD".

if --dest-password is not provided, the cli will ask for "Destination Password"

the extension is working as expected, i tested it locally.

[codecov-io]

Codecov Report

Merging #11384 into master will increase coverage by 0.01%.
The diff coverage is 8.69%.

@@            Coverage Diff             @@
##           master   #11384      +/-   ##
==========================================
+ Coverage   64.11%   64.13%   +0.01%     
==========================================
  Files         403      403              
  Lines       37973    37995      +22     
==========================================
+ Hits        24348    24367      +19     
- Misses      11995    11999       +4     
+ Partials     1630     1629       -1

Impacted Files	Coverage Δ
etcdctl/ctlv3/command/make_mirror_command.go	13.88% <8.69%> (-1.23%)	⬇️
etcdserver/api/v3rpc/lease.go	67.04% <0%> (-7.96%)	⬇️
pkg/netutil/netutil.go	63.11% <0%> (-5.74%)	⬇️
proxy/grpcproxy/watcher.go	85.71% <0%> (-4.09%)	⬇️
client/keys.go	85.42% <0%> (-4.03%)	⬇️
pkg/testutil/recorder.go	77.77% <0%> (-3.71%)	⬇️
lease/leasehttp/http.go	64.23% <0%> (-1.46%)	⬇️
auth/store.go	45.97% <0%> (-1.41%)	⬇️
pkg/adt/interval_tree.go	85.96% <0%> (-1.26%)	⬇️
etcdserver/v3_server.go	72.64% <0%> (-1.07%)	⬇️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec52217...db0e714. Read the comment docs.

[jingyih]

LGTM

[jingyih]

For reference: fixes #11383

[xiang90]

lgtm

[yvanadamov]

Hi Guys,

In which version is added this? I tried it in 3.4.13:

etcdctl make-mirror http://$IP:2379 --prefix=test --dest-user $USER:$PASSWORD

And I received:
Error: unknown flag: --dest-user

[spzala]

Hi Guys,

In which version is added this? I tried it in 3.4.13:

etcdctl make-mirror http://$IP:2379 --prefix=test --dest-user $USER:$PASSWORD

And I received:
Error: unknown flag: --dest-user

@yvanadamov I think this went into 3.4.15 - can you please check it? Thanks!

[JamesXNelson]

just fyi, these options are not documented, and it would be very helpful if they were in the command help / online documentation.

[xiang90]

@JamesXNelson

Maybe you could help submit a PR to get this documented :)