Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate check in confchange.Simple #11192

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Removed duplicate check in confchange.Simple #11192

merged 1 commit into from
Oct 4, 2019

Conversation

i-sevostyanov
Copy link
Contributor

confchange: Removed duplicate check in confchange.Simple.

Fixes #11189

spzala
spzala reviewed Oct 1, 2019
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks. Also, the checkAndReturn returns err vs nil (as in the removed code) which is better.
/cc @tbg

@tbg
Copy link
Contributor

tbg commented Oct 4, 2019

Thank you!

@tbg tbg merged commit 555eb19 into etcd-io:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate check in confchange.Simple
3 participants
@i-sevostyanov @tbg @spzala