Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: add store revision metrics #11126

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Sep 5, 2019

Add experimental metrics etcd_debugging_mvcc_current_revision and etcd_debugging_mvcc_compact_revision.

Add experimental metrics etcd_debugging_mvcc_current_revision and
etcd_debugging_mvcc_compact_revision.
@jingyih jingyih requested review from gyuho and spzala September 5, 2019 22:46
@jingyih
Copy link
Contributor Author

jingyih commented Sep 5, 2019

Have we seen this functional test error before?

{"level":"warn","ts":"2019-09-05T22:55:57.643Z","caller":"etcdmain/etcd.go:176","msg":"failed to start etcd","error":"cannot fetch cluster info from peer urls: could not retrieve cluster information from the given URLs"}
{"level":"fatal","ts":"2019-09-05T22:55:57.643Z","caller":"etcdmain/etcd.go:271","msg":"discovery failed","error":"cannot fetch cluster info from peer urls: could not retrieve cluster information from the given URLs","stacktrace":"go.etcd.io/etcd/etcdmain.startEtcdOrProxyV2\n\t/go/src/go.etcd.io/etcd/etcdmain/etcd.go:271\ngo.etcd.io/etcd/etcdmain.Main\n\t/go/src/go.etcd.io/etcd/etcdmain/main.go:46\nmain.main\n\t/go/src/go.etcd.io/etcd/main.go:28\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:200"}

@jingyih
Copy link
Contributor Author

jingyih commented Sep 5, 2019

cc @wenjiaswe

@wenjiaswe
Copy link
Contributor

@jingyih No, all functional test passes when running locally.

@wenjiaswe
Copy link
Contributor

lgtm, thanks!

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. I believe this should be added in the changelog though. Thanks @jingyih !!

@jingyih
Copy link
Contributor Author

jingyih commented Sep 5, 2019

LGTM too. I believe this should be added in the changelog though. Thanks @jingyih !!

Thanks for reminding!

@jingyih jingyih merged commit fc8f29b into etcd-io:master Sep 5, 2019
@wenjiaswe
Copy link
Contributor

By the way, I think we could cherry pick metrics back to previous versions right? Could we cherry pick it to 3.2, 3.3. and 3.4?

@jingyih jingyih deleted the add_metric_store_revision branch September 5, 2019 23:48
@jingyih
Copy link
Contributor Author

jingyih commented Sep 5, 2019

By the way, I think we could cherry pick metrics back to previous versions right? Could we cherry pick it to 3.2, 3.3. and 3.4?

Sounds good.

spzala added a commit that referenced this pull request Sep 6, 2019
jingyih added a commit that referenced this pull request Sep 7, 2019
…6-origin-release-3.4

Automated cherry pick of #11126 on release-3.4
jingyih added a commit that referenced this pull request Sep 7, 2019
…6-origin-release-3.3

Automated cherry pick of #11126 on release-3.3
jingyih added a commit that referenced this pull request Sep 7, 2019
…6-origin-release-3.2

Automated cherry pick of #11126 on release-3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants