Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update test Go version / release version #11110

Merged
merged 7 commits into from
Sep 6, 2019
Merged

*: update test Go version / release version #11110

merged 7 commits into from
Sep 6, 2019

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 3, 2019

Test images have been uploaded already.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 3, 2019

/cc @jingyih

@gyuho
Copy link
Contributor Author

gyuho commented Sep 5, 2019

TLS cipher suite tests are failing in 1.13.....

@gyuho gyuho added the WIP label Sep 5, 2019
@vimalk78
Copy link
Contributor

vimalk78 commented Sep 5, 2019

will setting the TLS Max version to TLS12 in integration/TestTLSClientCipherSuitesMismatch help here?
I tested locally with go1.13 and the test case passes.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 5, 2019

@vimalk78 Could you help fix?

@vimalk78
Copy link
Contributor

vimalk78 commented Sep 6, 2019

@vimalk78 Could you help fix?

yes @gyuho , sent #11129

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented Sep 6, 2019

# internal/cpu

flag provided but not defined: -unsafeptr

shadow: check for possible unintended shadowing of variables

Usage: shadow [-flag] [package]

This analyzer check for shadowed variables.

A shadowed variable is a variable declared in an inner scope

with the same name and type as a variable in an outer scope,

and where the outer variable is mentioned after the inner one

is declared.

(This definition can be refined; the module generates too many

false positives and is not yet enabled by default.)

For example:

	func BadRead(f *os.File, buf []byte) error {

		var err error

		for {

			n, err := f.Read(buf) // shadows the function variable 'err'

			if err != nil {

				break // causes return of wrong value

			}

			foo(buf)

		}

		return err

	}

Flags:  -V	print version and exit

  -all

    	no effect (deprecated)

  -c int

    	display offending line with this many lines of context (default -1)

  -cpuprofile string

    	write CPU profile to this file

  -debug string

    	debug flags, any subset of "fpstv"

  -fix

    	apply all suggested fixes

  -flags

    	print analyzer flags in JSON

  -json

    	emit JSON output

  -memprofile string

    	write memory profile to this file

  -source

    	no effect (deprecated)

  -strict

    	whether to be strict about shadowing; can be noisy

  -tags string

    	no effect (deprecated)

  -trace string

    	write trace log to this file

  -v	no effect (deprecated)

# internal/bytealg

flag provided but not defined: -unsafeptr

shadow: check for possible unintended shadowing of variables

Skipping go vet tests...

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho merged commit d2c2130 into etcd-io:master Sep 6, 2019
@gyuho gyuho deleted the go branch September 6, 2019 20:16
@serathius serathius mentioned this pull request Nov 26, 2021
@tsaarni tsaarni mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants