clientv3/concurrency.Mutex.Lock() - preserve invariant #10153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funny-falcon
force-pushed
the
fix-client-mutex-lock-10111
branch
from
dd46a9f
to
1d624bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #10153 +/- ##
==========================================
+ Coverage 71.54% 71.71% +0.16%
==========================================
Files 390 390
Lines 36307 36306 -1
==========================================
+ Hits 25975 26036 +61
+ Misses 8530 8461 -69
- Partials 1802 1809 +7
Continue to review full report at Codecov.
|
Convenient invariant:
- if werr == nil then lock is supposed to be locked at the moment.
While we could not be confident in stronger invariant ('is exactly locked'),
it were inconvenient that previous code could return `werr == nil` after
Mutex.Unlock.
It could happen when ctx is canceled/timeouted exactly after waitDeletes
successfully returned werr == nil and before `<-ctx.Done()` checked.
While such situation is very rare, it is still possible.
fixes etcd-io#10111
funny-falcon
force-pushed
the
fix-client-mutex-lock-10111
branch
from
1d624bb
to
64e8b2e
Compare
gyuho
approved these changes
Oct 5, 2018
|
lgtm. Thanks for fixing. |
|
lgtm |
|
@jingyih Sounds good. Could you also update the changelogs as we backport? Thanks! |
This was referenced Oct 8, 2018
jingyih
added a commit
to jingyih/etcd
that referenced
this pull request
Oct 9, 2018
jingyih
added a commit
that referenced
this pull request
Oct 9, 2018
…3-origin-release-3.3 clientv3: automated cherry pick of #10153 to release-3.3
jingyih
added a commit
that referenced
this pull request
Oct 9, 2018
…3-origin-release-3.2 clientv3: automated cherry pick of #10153 to release-3.2
jingyih
added a commit
that referenced
this pull request
Oct 9, 2018
…3-origin-release-3.1 clientv3: automated cherry pick of #10153 to release 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenient invariant:
While we could not be confident in stronger invariant ('is exactly locked'),
it were inconvenient that previous code could return
werr == nilwhenit released Lock.
It could happen when ctx is canceled/timeouted exactly after waitDeletes
successfully returned werr == nil and before
<-ctx.Done()checked.While such situation is very rare, it is still possible.
fixes #10111