Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: fix goword checking in config.go #10149

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Oct 3, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #10149 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10149      +/-   ##
==========================================
+ Coverage   71.69%   71.95%   +0.26%     
==========================================
  Files         390      390              
  Lines       36307    36307              
==========================================
+ Hits        26029    26126      +97     
+ Misses       8474     8388      -86     
+ Partials     1804     1793      -11
Impacted Files Coverage Δ
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
etcdserver/api/v3rpc/watch.go 83.66% <0%> (-0.99%) ⬇️
etcdserver/v3_server.go 80.09% <0%> (+0.45%) ⬆️
etcdserver/server.go 75.08% <0%> (+0.57%) ⬆️
pkg/proxy/server.go 60.87% <0%> (+0.67%) ⬆️
etcdserver/cluster_util.go 59.64% <0%> (+0.89%) ⬆️
etcdserver/api/rafthttp/peer.go 79.88% <0%> (+1.11%) ⬆️
etcdserver/api/v2http/client.go 86.72% <0%> (+1.2%) ⬆️
pkg/schedule/schedule.go 83.09% <0%> (+1.4%) ⬆️
raft/node.go 92.72% <0%> (+1.53%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdfaf5...7d57ee3. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho gyuho merged commit eca5f03 into etcd-io:master Oct 3, 2018
@jingyih jingyih deleted the fix_goword_checking_in_clientv3 branch September 7, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants