Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-proxy doesn't respect --keys-only flag #8478

Closed
pjjw opened this issue Aug 31, 2017 · 2 comments
Closed

grpc-proxy doesn't respect --keys-only flag #8478

pjjw opened this issue Aug 31, 2017 · 2 comments
Milestone

Comments

@pjjw
Copy link
Contributor

pjjw commented Aug 31, 2017

Investigating the use of the grpc-proxy, I get different results for the same etcdctl command when going through the proxy vs. going direct to the etcd cluster- specifically, the --keys-only flag is ignored.

I'm running the grpc proxy with the following command:

pwoodman@mk8s01-dca1:~/etcd/etcd-v3.2.6-linux-amd64$ ./etcd grpc-proxy start --endpoints=http://m3-kv02-dca1:2379
2017-08-31 22:21:17.272813 I | etcdmain: listening for grpc-proxy client requests on 127.0.0.1:23790
2017-08-31 22:21:17.289372 E | etcdmain: forgot to set Type=notify in systemd service file?

I'd expect the following two commands to return the same result, but they don't:

pwoodman@mk8s01-dca1:~/etcd/etcd-v3.2.6-linux-amd64$ ETCDCTL_API=3 ./etcdctl --endpoints=http://m3-kv02-dca1:2379 get --keys-only --prefix "_sd.metadata"
_sd.metadata/hist_production_1r/statsdex_m3dbnode

_sd.metadata/hist_production_5f/statsdex_m3dbnode

_sd.metadata/integration_dca1/statsdex_m3dbnode

_sd.metadata/meta/statsdex_m3dbingester

_sd.metadata/meta/statsdex_m3dbnode

_sd.metadata/production/statsdex_m3dbingester

_sd.metadata/production/statsdex_m3dbnode

_sd.metadata/production_hist_backfill/statsdex_m3dbnode

pwoodman@mk8s01-dca1:~/etcd/etcd-v3.2.6-linux-amd64$ ETCDCTL_API=3 ./etcdctl --endpoints=http://localhost:23790 get --keys-only --prefix "_sd.metadata"
_sd.metadata/hist_production_1r/statsdex_m3dbnode
�0������ȯ�%
_sd.metadata/hist_production_5f/statsdex_m3dbnode
�0������ȯ�%
_sd.metadata/integration_dca1/statsdex_m3dbnode
�0������ȯ�%
_sd.metadata/meta/statsdex_m3dbingester
�G������ȯ�%
_sd.metadata/meta/statsdex_m3dbnode
�G������ȯ�%
_sd.metadata/production/statsdex_m3dbingester
�0������ȯ�%
_sd.metadata/production/statsdex_m3dbnode
�0������ȯ�%
_sd.metadata/production_hist_backfill/statsdex_m3dbnode
�0������ȯ�%
pwoodman@mk8s01-dca1:~/etcd/etcd-v3.2.6-linux-amd64$
@xiang90
Copy link
Contributor

xiang90 commented Aug 31, 2017

@pjjw Probably a bug. Would you like to help to get it fixed?

@pjjw
Copy link
Contributor Author

pjjw commented Sep 1, 2017 via email

@heyitsanthony heyitsanthony self-assigned this Sep 12, 2017
@heyitsanthony heyitsanthony added this to the v3.3.0 milestone Sep 12, 2017
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this issue Sep 13, 2017
gyuho pushed a commit that referenced this issue Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants