Merge pull request #10975 from lzhfromustc/currentRev

Add critical section to protect s.currentRev
etcd-io · Sep 6, 2019 · 88d998b · 88d998b
2 parents 64b3e59 + 077dd74
commit 88d998b
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/mvcc/kvstore.go b/mvcc/kvstore.go
@@ -176,6 +176,7 @@ func (s *store) compactBarrier(ctx context.Context, ch chan struct{}) {
 }
 
 func (s *store) Hash() (hash uint32, revision int64, err error) {
+	// TODO: hash and revision could be inconsistent, one possible fix is to add s.revMu.RLock() at the beginning of function, which is costly
 	start := time.Now()
 
 	s.b.ForceCommit()