Add log #624
Merged
Add log #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
…fore testing the nullity of tx.db, it may panic. Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
|
@ahrtr had to rebase because the last commit i cherrypicked had no sign-off :/ |
|
lgtm, generally. Why are we rolling our own logger based on go/log btw? |
|
Thanks @tjungblu We can use diff logger, but we follow the same as in |
Please read conversation in #509, especially #509 (comment) |
|
can we merge this ? |
|
ping @ahrtr @serathius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add logger to bbolt, see https://github.com/etcd-io/raft/blob/main/logger.go
Fixes #509
This PR is a continuation of #513
cc @ahrtr @fuweid