Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open bbolt database with file mode 0600 instead of 0666 #545

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Open bbolt database with file mode 0600 instead of 0666 #545

merged 2 commits into from
Jul 29, 2023

Conversation

ishan16696
Copy link
Contributor

@ishan16696 ishan16696 commented Jul 29, 2023 •
edited
Loading

Fix: #544

Note for reviewers:
compact bbolt command is using file mode 0444 to open the bbolt database.

bbolt/cmd/bbolt/main.go

Line 1655 in 39d812b

src, err := bolt.Open(cmd.SrcPath, 0444, &bolt.Options{ReadOnly: true})

I have updated the file mode to 0400 in compact sub-command. I hope this fine if not then I can revert it back to 0444.

@ishan16696
Fix tests to open a bbolt database with file mode:0600 instead of 0666.
c0b6749 
Signed-off-by: Ishan Tyagi <ishantyagi25@gmail.com>
@ishan16696
Fix bbolt command-line commands to open a bbolt database with file mo…
65759b6 
…de:0600 instead of 0666.

Fix bbolt command-line command: compact to open a bbolt database with file mode:0400 instead of 0444

Signed-off-by: Ishan Tyagi <ishantyagi25@gmail.com>
@ahrtr ahrtr merged commit d0a911e into etcd-io:master Jul 29, 2023
9 checks passed
@ishan16696 ishan16696 deleted the openDb/fixfileMode branch July 29, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bbolt db is opened with file mode 0666 in many places
2 participants
@ishan16696 @ahrtr