Fix deletion of non-existing keys #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now the test fails and tries to delete the next key returned by the cursor, which happens to be a nested bucket. That's why Delete is fails. Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Doc for Bucket.Delete says that a Delete() on non-existing key is a no-op. Right now it tries to delete the next key returned by the cursor. Fix this by checking for key equivalence before deletion. Fixes boltdb#349 Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
AskAlexSharov
added a commit
to ledgerwatch/bolt
that referenced
this pull request
Apr 1, 2020
AskAlexSharov
added a commit
to ledgerwatch/bolt
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via boltdb/bolt#660; looks important
Change Bucket.Delete to do what its doc comment says in a case of non-existing keys, e.g. nothing.
This pull request fixes boltdb#349