Skip to content

Commit

Permalink
pythongh-120754: Update estimated_size in C truncate (python#121357)
Browse files Browse the repository at this point in the history
Sometimes a large file is truncated (test_largefile). While
estimated_size is used as a estimate (the read will stil get the number
of bytes in the file), that it is much larger than the actual size of
data can result in a significant over allocation and sometimes lead to
a MemoryError / running out of memory.

This brings the C implementation to match the Python _pyio
implementation.
  • Loading branch information
cmaloney authored and estyxx committed Jul 17, 2024
1 parent 45b3734 commit b894d38
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Modules/_io/fileio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1094,6 +1094,12 @@ _io_FileIO_truncate_impl(fileio *self, PyTypeObject *cls, PyObject *posobj)
return NULL;
}

/* Sometimes a large file is truncated. While estimated_size is used as a
estimate, that it is much larger than the actual size can result in a
significant over allocation and sometimes a MemoryError / running out of
memory. */
self->estimated_size = pos;

return posobj;
}
#endif /* HAVE_FTRUNCATE */
Expand Down

0 comments on commit b894d38

Please sign in to comment.