Warning about conflicts with css order of importing #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brenosalv
added
the
tech debt
|
Visit the preview URL for this PR (updated for commit d7ce5d2): https://estuary-marketing--pr475-brenosalv-tech-debt-2v6gxzmf.web.app (expires Thu, 03 Oct 2024 18:14:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
added 2 commits
September 2, 2024 18:33
travjenkins
reviewed
Sep 3, 2024
|
Fixing another warning: It seems like this happens when we set |
travjenkins
reviewed
Sep 3, 2024
gatsby-node.ts
Outdated
| @@ -445,3 +445,16 @@ export const createResolvers: GatsbyNode['createResolvers'] = async ({ | |||
| }, | |||
| }); | |||
| }; | |||
|
|
|||
| export const onCreateWebpackConfig = ({ stage, actions, getConfig }) => { | |||
| if (stage === 'develop') { | |||
There was a problem hiding this comment.
I think we should probably keep this on for build-javascript as well.
I know the warning does not show up in prod but probably good to keep these configs in sync.
travjenkins
reviewed
Sep 3, 2024
travjenkins
approved these changes
Sep 3, 2024
travjenkins
deleted the
Brenosalv/tech-debt/css-order-conflicts-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests / Screenshots