Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brenosalv/bug/estuary-logo-does-not-appear-in-safari #417

Merged

Conversation

Brenosalv
Copy link
Collaborator

#416

Changes

  • Estuary logo does not appear on first sections of integration page on Safari browser. We expect it to appear.

Tests / Screenshots

  • scenarios you tested with screenshots

@Brenosalv Brenosalv added the bug Something isn't working label Jul 23, 2024
@Brenosalv Brenosalv self-assigned this Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Visit the preview URL for this PR (updated for commit 6d1a17e):

https://estuary-marketing--pr417-brenosalv-bug-estuar-6ssvq1y5.web.app

(expires Thu, 22 Aug 2024 18:32:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@travjenkins
Copy link
Member

Hovering on the parent - see it in the HTML

image

Hovering on the SVG - nothing shows in the HTML

image

Added position and then hovering SVG - shows it in the html

image

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins merged commit bc0c89b into master Jul 23, 2024
1 check passed
@travjenkins travjenkins deleted the Brenosalv/bug/estuary-logo-does-not-appear-in-safari branch July 23, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estuary logo does not appear on first sections of integration page on Safari browser
2 participants