Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot: Fixing hubspot snapshot #1580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Luishfs
Copy link
Collaborator

@Luishfs Luishfs commented May 15, 2024

Description:

Simply updating the source-hubspot snapshot

Notes for reviewers:

This error still seem to be related to the source limitation, will write a fix propose in the comments


This change is Reviewable

@Luishfs Luishfs self-assigned this May 15, 2024
@Luishfs
Copy link
Collaborator Author

Luishfs commented May 15, 2024

@williamhbaker Are you in favor of limiting the amount of response data from the properties API to 3 or 5 so we can bypass this constant snapshot error?

@Luishfs
Copy link
Collaborator Author

Luishfs commented May 15, 2024

@williamhbaker For reference, i think this error happens because the atf connector hard-limits the amount of properties, so probably it leaves or adds new properties to the "main" if a new property comes in

@williamhbaker
Copy link
Member

I'm not up to speed on what's going on here so it's hard for me to weigh in. My initial take is that no we should not alter the connector output for the sake of conforming to a test snapshot, but I'm not sure if that's what you're suggesting. The changes in this pull request are adding a field to the schema, and I'm seeing the tests for source-hubspot passing, so I'm pretty confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants