Check that the node has a parent before matching a 'child' selector #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The child selector can try to match the left subselector to an undefined node when the right subselector matches to a top-level (i.e. parentless) node.
jviide
changed the title
marvinhagemeister
approved these changes
Feb 16, 2023
michaelficarra
approved these changes
Feb 16, 2023
|
Thanks for the quick fix @jviide. |
This was referenced Feb 16, 2023
Closed
davorpa
added a commit
to davorpa/omdb-search-react-app
that referenced
this pull request
Feb 16, 2023
esquery package is a transitive dependency for us - and a broken version was released last night. This commit fixes esquery to 1.4.2 since 1.4.1 is buggy See: estools/esquery#135 Patched by: estools/esquery#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The child selector can try to match the left subselector to an undefined node when the right subselector matches to a top-level (i.e. parentless) node.
This pull request addresses that issue and adds a regression test.
This fixes the crash from issue #135 on my setup when running ESLint with eslint-config-standard, as well as with the @typescript-eslint/require-await rule enabled. It might still be a good idea to consider merging #136 or #137 as well.