Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: Check eslintrc file #103

Merged
merged 1 commit into from
May 1, 2020
Merged

Linting: Check eslintrc file #103

merged 1 commit into from
May 1, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 26, 2020 •
edited
Loading

  • Linting: Check eslintrc file

@michaelficarra
Copy link
Member

I think these are both fine, but can you separate them into two PRs?

@brettz9 brettz9 mentioned this pull request May 1, 2020
Merged
@brettz9
Copy link
Contributor Author

brettz9 commented May 1, 2020 •
edited
Loading

Sure, I've amended to move the for-of to #106.

@michaelficarra michaelficarra changed the title - Linting: Check eslintrc file Linting: Check eslintrc file May 1, 2020
@michaelficarra michaelficarra merged commit 0334ec8 into estools:master May 1, 2020
@brettz9 brettz9 deleted the linting-eslintrc branch May 2, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettz9 @michaelficarra